Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18031#discussion_r117440204
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -121,48 +126,69 @@ private[spark] class CompressedMapStatus(
     }
     
     /**
    - * A [[MapStatus]] implementation that only stores the average size of 
non-empty blocks,
    - * plus a bitmap for tracking which blocks are empty.
    + * A [[MapStatus]] implementation that stores the accurate size of huge 
blocks, which are larger
    + * than both spark.shuffle.accurateBlockThreshold and
    + * spark.shuffle.accurateBlockThresholdByTimesAverage * averageSize. It 
stores the
    + * average size of other non-empty blocks, plus a bitmap for tracking 
which blocks are empty.
      *
      * @param loc location where the task is being executed
      * @param numNonEmptyBlocks the number of non-empty blocks
      * @param emptyBlocks a bitmap tracking which blocks are empty
      * @param avgSize average size of the non-empty blocks
    + * @param hugeBlockSizes sizes of huge blocks by their reduceId.
      */
     private[spark] class HighlyCompressedMapStatus private (
         private[this] var loc: BlockManagerId,
         private[this] var numNonEmptyBlocks: Int,
         private[this] var emptyBlocks: RoaringBitmap,
    -    private[this] var avgSize: Long)
    +    private[this] var avgSize: Long,
    +    @transient private var hugeBlockSizes: Map[Int, Byte])
    --- End diff --
    
    Can the size of this map become large?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to