Github user liyichao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18070#discussion_r118050668
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -338,6 +340,9 @@ private[spark] class Executor(
metricsSystem = env.metricsSystem)
threwException = false
res
+ } catch {
+ case _: CommitDeniedException =>
+ throw new TaskKilledException("commit denied")
--- End diff --
Maybe we should throw a more specific exception for the `already committed`
case ? Executor can know about the `already committed` case before it sends the
statusUpdate, so
we do not need to wait until the driver's statusUpdate.
It also seems ok to fix it up on the driver, I'll try it tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
