Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18076#discussion_r118139724
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -713,8 +718,15 @@ private[spark] class BlockManager(
       /**
        * Release a lock on the given block.
        */
    -  def releaseLock(blockId: BlockId): Unit = {
    -    blockInfoManager.unlock(blockId)
    +  def releaseLock(blockId: BlockId): Unit = releaseLock(blockId, 
taskAttemptId = None)
    --- End diff --
    
    In fact `BlockManager` extends `BlockDataManager`, so it have to override 
the `releaseLock(blockId: BlockId)` method, thus we keep this and implement a 
new method that accepts the new argument `taskAttemptId`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to