Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18076#discussion_r118144178
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala ---
@@ -281,22 +281,27 @@ private[storage] class BlockInfoManager extends
Logging {
/**
* Release a lock on the given block.
+ * In case a TaskContext is not propagated properly to all child threads
for the task, we fail to
+ * get the TID from TaskContext, so we have to explicitly pass the TID
value to release the lock.
+ *
+ * See SPARK-18406 for more discussion of this issue.
*/
- def unlock(blockId: BlockId): Unit = synchronized {
- logTrace(s"Task $currentTaskAttemptId releasing lock for $blockId")
+ def unlock(blockId: BlockId, taskAttemptId: Option[TaskAttemptId] =
None): Unit = synchronized {
--- End diff --
if we are going to overwrite it, we should not set a default value for
parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
