Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18074#discussion_r118457024
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
---
@@ -153,19 +153,24 @@ case class WindowExec(
}
/**
- * Collection containing an entry for each window frame to process. Each
entry contains a frames'
- * WindowExpressions and factory function for the WindowFrameFunction.
+ * Collection containing an entry for each window frame to process. Each
entry contains a frame's
+ * [[WindowExpression]]s and factory function for the
WindowFrameFunction.
*/
- private[this] lazy val windowFrameExpressionFactoryPairs = {
+ private[this] lazy val windowFrameExpressionFactoryPairs:
+ Seq[(mutable.Buffer[WindowExpression], InternalRow =>
WindowFunctionFrame)] =
+ {
type FrameKey = (String, FrameType, Option[Int], Option[Int])
type ExpressionBuffer = mutable.Buffer[Expression]
- val framedFunctions = mutable.Map.empty[FrameKey, (ExpressionBuffer,
ExpressionBuffer)]
+ type WindowExpressionBuffer = mutable.Buffer[WindowExpression]
+ val framedFunctions = mutable.Map.empty[FrameKey,
(WindowExpressionBuffer, ExpressionBuffer)]
// Add a function and its function to the map for a given frame.
- def collect(tpe: String, fr: SpecifiedWindowFrame, e: Expression, fn:
Expression): Unit = {
+ def collect(
+ tpe: String, fr: SpecifiedWindowFrame, e: WindowExpression, fn:
Expression): Unit =
--- End diff --
This changed a type, which could be fine as it's an internal method, but
why should it be the more specific type? this isn't a doc change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
