Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/17113#discussion_r119152848
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -54,7 +54,7 @@ import org.apache.spark.util.{AccumulatorV2, ThreadUtils,
Utils}
private[spark] class TaskSchedulerImpl private[scheduler](
val sc: SparkContext,
val maxTaskFailures: Int,
- private[scheduler] val blacklistTrackerOpt: Option[BlacklistTracker],
+ mockBlacklistTracker: Option[BlacklistTracker] = None,
--- End diff --
whats the point of this refactoring? I think I see the point -- you are
showing that these constructors are only directly called w/ a mock blacklist
tracker, but overall I think it actually makes it harder to understand the
code, its odd to see something called "mock" in the main code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
