Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/17113#discussion_r119366199
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -51,29 +51,19 @@ import org.apache.spark.util.{AccumulatorV2,
ThreadUtils, Utils}
* acquire a lock on us, so we need to make sure that we don't try to lock
the backend while
* we are holding a lock on ourselves.
*/
-private[spark] class TaskSchedulerImpl private[scheduler](
+private[spark] class TaskSchedulerImpl(
val sc: SparkContext,
val maxTaskFailures: Int,
- private[scheduler] val blacklistTrackerOpt: Option[BlacklistTracker],
isLocal: Boolean = false)
extends TaskScheduler with Logging {
import TaskSchedulerImpl._
def this(sc: SparkContext) = {
- this(
- sc,
- sc.conf.get(config.MAX_TASK_FAILURES),
- TaskSchedulerImpl.maybeCreateBlacklistTracker(sc))
+ this(sc, sc.conf.get(config.MAX_TASK_FAILURES))
}
- def this(sc: SparkContext, maxTaskFailures: Int, isLocal: Boolean) = {
- this(
- sc,
- maxTaskFailures,
- TaskSchedulerImpl.maybeCreateBlacklistTracker(sc),
- isLocal = isLocal)
- }
+ private[scheduler] lazy val blacklistTrackerOpt =
maybeCreateBlacklistTracker(sc)
--- End diff --
A comment here as to why we do this would be good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
