Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18257#discussion_r121271167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -482,11 +482,17 @@ case class Sort(
/** Factory for constructing new `Range` nodes. */
object Range {
- def apply(start: Long, end: Long, step: Long, numSlices: Option[Int]):
Range = {
+ def apply(start: Long, end: Long, step: Long, numSlices: Option[Int])
+ : LeafNode with MultiInstanceRelation = {
val output = StructType(StructField("id", LongType, nullable = false)
:: Nil).toAttributes
- new Range(start, end, step, numSlices, output)
+ if (start == end || (start < end ^ 0 < step)) {
+ LocalRelation(output)
--- End diff --
It looks a bit weird to see a `LocalRelation` node when constructing a
`Range` node.
If possible, I'd let the empty `Range` keeps its wrong parameters as is. So
the logical plan can be consistent with input query. And only turning it to
empty relation when planning the query.
Of course this involves few change in Range's planning. So I'm ok with
current solution too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
