Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18257#discussion_r121271275
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -482,11 +482,17 @@ case class Sort(
     
     /** Factory for constructing new `Range` nodes. */
     object Range {
    -  def apply(start: Long, end: Long, step: Long, numSlices: Option[Int]): 
Range = {
    +  def apply(start: Long, end: Long, step: Long, numSlices: Option[Int])
    +      : LeafNode with MultiInstanceRelation = {
         val output = StructType(StructField("id", LongType, nullable = false) 
:: Nil).toAttributes
    -    new Range(start, end, step, numSlices, output)
    +    if (start == end || (start < end ^ 0 < step)) {
    +      LocalRelation(output)
    --- End diff --
    
    Hmm, I think doing it in optimization sounds not ok for me too. It's not an 
optimization actually. Anyway, let's wait for other comments. Maybe there's 
other good ways to do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to