Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17865#discussion_r121541415
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -206,17 +227,20 @@ def _():
     @since(1.3)
     def approxCountDistinct(col, rsd=None):
         """
    -    .. note:: Deprecated in 2.1, use approx_count_distinct instead.
    +    .. note:: Deprecated in 2.1, use :func:`approx_count_distinct` instead.
         """
         return approx_count_distinct(col, rsd)
     
     
     @since(2.1)
     def approx_count_distinct(col, rsd=None):
    -    """Returns a new :class:`Column` for approximate distinct count of 
``col``.
    +    """Returns a new :class:`Column` for approximate distinct count of 
column `col`.
     
    -    >>> df.agg(approx_count_distinct(df.age).alias('c')).collect()
    -    [Row(c=2)]
    +    :param rsd: Residual (float). The approximate count will be within 
this fraction of the true
    --- End diff --
    
    For this one, let's add the contents in Scala/R one too - 
https://github.com/apache/spark/blob/3a840048ed3501e06260b7c5df18cc0bbdb1505c/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L245
 and 
https://github.com/apache/spark/blob/7f203a248f94df6183a4bc4642a3d873171fef29/R/pkg/R/functions.R#L2243
    
    This one in Scala/R look already having the param contents to match with.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to