Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17865#discussion_r121543259
--- Diff: python/pyspark/sql/functions.py ---
@@ -962,9 +993,9 @@ def add_months(start, months):
"""
Returns the date that is `months` months after `start`
- >>> df = spark.createDataFrame([('2015-04-08',)], ['d'])
- >>> df.select(add_months(df.d, 1).alias('d')).collect()
- [Row(d=datetime.date(2015, 5, 8))]
+ >>> df = spark.createDataFrame([('2015-04-08',)], ['dt'])
--- End diff --
I think changing arbitrary name to `dt` or `ts` is fine but not worth
changing `t`, `timestamp`, `d` or `date`. These are already readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
