Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18320#discussion_r122606765
  
    --- Diff: R/pkg/inst/worker/daemon.R ---
    @@ -47,8 +55,6 @@ while (TRUE) {
           close(inputCon)
           Sys.setenv(SPARKR_WORKER_PORT = port)
           try(source(script))
    -      # Set SIGUSR1 so that child can exit
    -      tools::pskill(Sys.getpid(), tools::SIGUSR1)
           parallel:::mcexit(0L)
    --- End diff --
    
    BTW, up to my knowledge, this should work alone, at least in C (< I didn't 
test). Even if it was a bug in R and is fixed in the future, I guess the 
current logics would still work with the current status.
    
    ```R
    arbitrary <- 9999
    tools::pskill(arbitrary, tools::SIGUSR1)
    ```
    
    https://stat.ethz.ch/R-manual/R-devel/library/tools/html/pskill.html
    
    > it silently ignores invalid values of its arguments, including zero or 
negative pids.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to