Github user jimjh commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57070773
@rxin Thanks for your feedback. I agree with almost all of your comments
and made the appropriate changes. However, I don't think it should be an
abstract class. According to Programming in Scala: _To trait or not to trait_,
> If it might be reused in multiple, unrelated classes, make it a trait.
Only traits can be mixed into different parts of the class hierarchy.
`Spillable` seems to fit that criteria.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
