Github user jimjh commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-57102492
@rxin You made a good point, and I understand that traits with default
implementations are not Java-compatible and can cause binary compatibility
issues. Like you said, this might not be a big deal since we will always
compile `Spillable` and everything that uses `Spillable` together. Nothing
outside the `spark` package can use `Spillable`.
Another concern comes to mind: if we made `Spillable` an abstract class,
would it be more inconvenient to use in other collections in the future, since
each class may extend at most one abstract class?
I am actually ambivalent on this issue - it seems that either way has pros
and cons, and the none of the cons appear to be huge problems. Let me know if
you want me to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
