Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18403#discussion_r123722199
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1746,7 +1746,7 @@ def toPandas(self):
pdf = pd.DataFrame.from_records(self.collect(),
columns=self.columns)
for f, t in dtype.items():
- pdf[f] = pdf[f].astype(t, copy=False)
--- End diff --
@cloud-fan, @viirya and @BryanCutler, while I was testing this, I realised
that actually it looks `copy` is exposed from 0.13.0. I was confused that it
was added from 0.11.0 -
[here](https://github.com/pandas-dev/pandas/blob/v0.11.0/pandas/core/generic.py#L521).
However, it sounds hidden from 0.11.0 to 0.12.0.
What do you think about this? I think it sounds safer to not use it for now
(as I found the doc says we should be careful) and we can support Pandas 0.11.0
and 0.12.0.
It is still not a big deal maybe. 0.13.0 was released 3.5 years ago. Please
let me know. I can just fix the version to 0.13.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
