Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18403#discussion_r123725824
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1746,7 +1746,7 @@ def toPandas(self):
pdf = pd.DataFrame.from_records(self.collect(),
columns=self.columns)
for f, t in dtype.items():
- pdf[f] = pdf[f].astype(t, copy=False)
--- End diff --
Hmm, I guess it says we should be careful when using it, is because if
`copy = False`, you may unintentionally change the data of previous DataFrame
that shares the same data.
I have no strong opinion for using `copy = False`. But as you said, I think
it's fine to set the version as 0.13.0. Let's see others' opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
