Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r123982222
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -80,7 +80,7 @@ private[shared] object SharedParamsCodeGen {
ParamDesc[String]("weightCol", "weight column name. If this is not
set or empty, we treat " +
"all instance weights as 1.0"),
ParamDesc[String]("solver", "the solver algorithm for optimization.
If this is not set or " +
- "empty, default value is 'auto'", Some("\"auto\"")),
+ "empty, default value is 'auto'", finalFields = false),
--- End diff --
Why remove default value? Can we still keep a default value for the most
common case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
