Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r123982677
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -97,6 +97,7 @@ private[shared] object SharedParamsCodeGen {
doc: String,
defaultValueStr: Option[String] = None,
isValid: String = "",
+ finalFields: Boolean = true,
--- End diff --
Can we combine ```finalFields``` and ```finalMethods``` as ```is
FinalParam```? If the set/get methods are non-final, it makes sense to get a
non-final param.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
