Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18305#discussion_r124238951
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/aggregator/DifferentiableLossAggregatorSuite.scala
---
@@ -157,4 +160,38 @@ object DifferentiableLossAggregatorSuite {
this
}
}
+
+ /** Get feature and label summarizers for provided data. */
+ private[ml] def getRegressionSummarizers(
--- End diff --
Seems like these convenience functions could be adapted to also be used in
both in `train` logic across the linear models as well as here in the tests?
Since the `seqOp` and `comboOp` are defined multiple times everywhere.
Though that could be done in a later clean up PR perhaps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
