Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18305#discussion_r124241031
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/loss/RDDLossFunctionSuite.scala
---
@@ -46,11 +46,11 @@ class RDDLossFunctionSuite extends SparkFunSuite with
MLlibTestSparkContext {
val lossWithReg = new RDDLossFunction(instances, getAgg,
Some(regLossFun))
val (loss1, grad1) =
lossNoReg.calculate(coefficients.asBreeze.toDenseVector)
- val (regLoss, regGrad) = regLossFun.calculate(coefficients.toArray)
+ val (regLoss, regGrad) = regLossFun.calculate(coefficients)
--- End diff --
Again this serves to highlight the inconsistency - the loss fn and reg loss
fn should be composable IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
