Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18469#discussion_r124913758
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/CatalystTestUtils.scala
---
@@ -37,4 +40,32 @@ object DateTimeTestUtils {
DateTimeUtils.resetThreadLocals()
}
}
+
+ /**
+ * Sets all SQL configurations specified in `pairs`, calls `f`, and then
restore all SQL
+ * configurations.
+ */
+ protected def withSQLConf(pairs: (String, String)*)(f: => Unit): Unit = {
--- End diff --
Hi, @gatorsmile .
Then, what about removing `withSQLConf` from `SQLTestUtils` instead of
having duplicated logic?
Since this is `trait`, I think we can do that in this PR, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
