Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18416#discussion_r125556076
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
    @@ -498,6 +520,19 @@ object ScalaReflection extends ScalaReflection {
               serializerFor(_, valueType, valuePath, seenTypeSet),
               valueNullable = !valueType.typeSymbol.asClass.isPrimitive)
     
    +      case t if t <:< localTypeOf[scala.collection.Set[_]] =>
    +        val TypeRef(_, _, Seq(elementType)) = t
    +
    +        // There's no corresponding Catalyst type for `Set`, we serialize 
a `Set` to Catalyst array.
    +        // Note that the property of `Set` is only kept when manipulating 
the data as domain object.
    +        val newInput =
    +          Invoke(
    +           inputObject,
    +           "toSeq",
    +           ObjectType(classOf[Seq[_]]))
    --- End diff --
    
    For primitive, calling `toArray` can directly construct `UnsafeArrayData` 
in `toCatalystArray`. However, `toArray` requires a `ClassTag`. To generate it 
with a `StaticInvoke` might be hacky. So for now I simply use `toSeq`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to