Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18416#discussion_r125824114
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -326,7 +329,10 @@ object ScalaReflection extends ScalaReflection {
val companion =
t.normalize.typeSymbol.companionSymbol.typeSignature
val cls = companion.declaration(newTermName("newBuilder")) match {
- case NoSymbol => classOf[Seq[_]]
+ // It always returns `NoSymbol` for set classes. But we can't
simply use the class of
--- End diff --
this may not be safe if a `Set` implementation doesn't have the
`newBuilder` method, can we spend a little more time to investigate it? thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
