Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18503#discussion_r128133007
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -167,6 +167,7 @@ public UnsafeRow() {}
*/
public void pointTo(Object baseObject, long baseOffset, int sizeInBytes)
{
assert numFields >= 0 : "numFields (" + numFields + ") should >= 0";
+ assert sizeInBytes % 8 == 0 : "sizeInBytes (" + sizeInBytes + ")
should be a multiple of 8";
--- End diff --
I think we only need the assertion here, in `pointTo`, and in
`setTotalSize`. Other places are just checking length for existing unsafe rows,
which is unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
