Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/18503#discussion_r128408410
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
---
@@ -363,7 +363,8 @@ private[state] class HDFSBackedStateStoreProvider
extends StateStoreProvider wit
val valueRowBuffer = new Array[Byte](valueSize)
ByteStreams.readFully(input, valueRowBuffer, 0, valueSize)
val valueRow = new UnsafeRow(valueSchema.fields.length)
- valueRow.pointTo(valueRowBuffer, valueSize)
+ // If valueSize in existing file is not multiple of 8, round
it down to multiple of 8
+ valueRow.pointTo(valueRowBuffer, (valueSize / 8) * 8)
--- End diff --
This isnt rounding. This essentially floor to the multiple of 8.
@cloud-fan is this safe to do with ANY row generated in earlier Spark 2.0
- 2.2? I want to be 100% sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
