Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18630#discussion_r128646482
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
    @@ -66,4 +77,68 @@ object DriverWrapper {
             System.exit(-1)
         }
       }
    +
    +  // R or Python are not supported in cluster mode so download the jars to 
the driver side
    +  private def setupDependencies(loader: MutableURLClassLoader, userJar: 
String): Unit = {
    +    val packagesExclusions = sys.props.get("spark.jars.excludes").orNull
    --- End diff --
    
    Hmm, this is too much copy & paste for my liking. Could you instead 
refactor this code into a helper class or object (e.g. `IvytUtils`)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to