Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18706#discussion_r129159285
  
    --- Diff: 
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
 ---
    @@ -243,7 +243,6 @@ public void 
initializeApplication(ApplicationInitializationContext context) {
         String appId = context.getApplicationId().toString();
         try {
           ByteBuffer shuffleSecret = context.getApplicationDataForService();
    -      logger.info("Initializing application {}", appId);
    --- End diff --
    
    I rebuilt my cluster this morning so I don't have the logs anymore... but 
what I noticed is that this callback gets called multiple times (once per 
container belonging to the app), while I only remember the stop callback being 
called when the application actually stops. So it didn't seem like the behavior 
was as symmetric as one would expect.
    
    But the secret manager also prints an info message on unregistration, so I 
guess the important things are still logged even if these two messages are 
removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to