GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/18706

    [SPARK-21494][network] Use correct app id when authenticating to external 
service.

    There was some code based on the old SASL handler in the new auth client 
that
    was incorrectly using the SASL user as the user to authenticate against the
    external shuffle service. This caused the external service to not be able to
    find the correct secret to authenticate the connection, failing the 
connection.
    
    In the course of debugging, I found that some log messages from the YARN 
shuffle
    service were a little noisy, so I silenced some of them, and also added a 
couple
    of new ones that helped find this issue. On top of that, I found that a 
check
    in the code that recording app secrets was wrong, causing more log spam and 
also
    using an O(n) operation instead of an O(1) call.
    
    Also added a new integration suite for the YARN shuffle service with auth 
on,
    and verified it failed before, and passes now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-21494

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18706.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18706
    
----
commit 4e6cc532009efd2325be97c262f37e154ac17370
Author: Marcelo Vanzin <[email protected]>
Date:   2017-07-21T17:35:54Z

    [SPARK-21494][network] Use correct app id when authenticating to external 
service.
    
    There was some code based on the old SASL handler in the new auth client 
that
    was incorrectly using the SASL user as the user to authenticate against the
    external shuffle service. This caused the external service to not be able to
    find the correct secret to authenticate the connection, failing the 
connection.
    
    In the course of debugging, I found that some log messages from the YARN 
shuffle
    service were a little noisy, so I silenced some of them, and also added a 
couple
    of new ones that helped find this issue. On top of that, I found that a 
check
    in the code that recording app secrets was wrong, causing more log spam and 
also
    using an O(n) operation instead of an O(1) call.
    
    Also added a new integration suite for the YARN shuffle service with auth 
on,
    and verified it failed before, and passes now.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to