Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18695#discussion_r130515139
--- Diff: python/pyspark/broadcast.py ---
@@ -139,6 +140,24 @@ def __reduce__(self):
return _from_id, (self._jbroadcast.id(),)
+class BroadcastPickleRegistry(threading.local):
--- End diff --
I'm ok for both ways. :)
My only concern is in previous locking way is we lock it for dumping the
command. I'm not sure if the dumping can take long time for big command so we
prevent other threads to preparing their commands.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
