Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18695#discussion_r130668860
  
    --- Diff: python/pyspark/broadcast.py ---
    @@ -139,6 +140,24 @@ def __reduce__(self):
             return _from_id, (self._jbroadcast.id(),)
     
     
    +class BroadcastPickleRegistry(threading.local):
    --- End diff --
    
    Using the lock was a little more obvious what is going on, but it's better 
to not use a lock in case of pickling a large command like @viirya said.  Also, 
this way doesn't need to change any of the pickling code, so I prefer it too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to