[GitHub] spark pull request #18806: [SPARK-21600] The description of "this requires s...

[guoxiaolongzte]

Github user guoxiaolongzte commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18806#discussion_r130784995
  
    --- Diff: docs/configuration.md ---
    @@ -1638,7 +1638,7 @@ Apart from these, the following properties are also 
available, and may be useful
         For more detail, see the description
         <a href="job-scheduling.html#dynamic-resource-allocation">here</a>.
         <br><br>
    -    This requires <code>spark.shuffle.service.enabled</code> to be set.
    +    This requires <code>spark.shuffle.service.enabled</code> to be set 
true.
    --- End diff --
    
    You are right, but usually is not very sure. Can not let the user to guess, 
the document needs to be accurately described. In addition, the spark project, 
several other are clearly described, spark.shuffle.service.enabled set true.
    
![1](https://user-images.githubusercontent.com/26266482/28858102-e488331a-7780-11e7-90da-9390d1659f35.png)
    
![2](https://user-images.githubusercontent.com/26266482/28858105-ecfb276e-7780-11e7-9f7f-b0d5448dcb62.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org