Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18806#discussion_r130787079 --- Diff: docs/configuration.md --- @@ -1638,7 +1638,7 @@ Apart from these, the following properties are also available, and may be useful For more detail, see the description <a href="job-scheduling.html#dynamic-resource-allocation">here</a>. <br><br> - This requires <code>spark.shuffle.service.enabled</code> to be set. + This requires <code>spark.shuffle.service.enabled</code> to be set true. --- End diff -- Since other places are clearly defined the property, so there should be no ambiguity. Personally I'm not fond of this super nit fix...
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org