Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18814#discussion_r131702902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -89,7 +89,11 @@ case class WindowSpecDefinition(
elements.mkString("(", " ", ")")
}
- private def isValidFrameType(ft: DataType): Boolean =
orderSpec.head.dataType == ft
+ private def isValidFrameType(ft: DataType): Boolean =
(orderSpec.head.dataType, ft) match {
+ case (DateType, IntegerType) => true
--- End diff --
can we check with other databases? seems `RANGE BETWEEN CURRENT ROW AND
interval 2 days FOLLOWING` is reasonable for date type column.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
