Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18814#discussion_r131876058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -89,7 +89,11 @@ case class WindowSpecDefinition(
elements.mkString("(", " ", ")")
}
- private def isValidFrameType(ft: DataType): Boolean =
orderSpec.head.dataType == ft
+ private def isValidFrameType(ft: DataType): Boolean =
(orderSpec.head.dataType, ft) match {
+ case (DateType, IntegerType) => true
--- End diff --
Yea, we should allow this, but this is a bit corner case and not very
straight-forward to implement, maybe we can leave this as a follow-up?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
