Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131727081
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
override def alterTableSchema(db: String, table: String, schema:
StructType): Unit = withClient {
requireTableExists(db, table)
val rawTable = getRawTable(db, table)
- val withNewSchema = rawTable.copy(schema = schema)
- verifyColumnNames(withNewSchema)
// Add table metadata such as table schema, partition columns, etc. to
table properties.
- val updatedTable = withNewSchema.copy(
- properties = withNewSchema.properties ++
tableMetaToTableProps(withNewSchema))
- try {
- client.alterTable(updatedTable)
- } catch {
- case NonFatal(e) =>
- val warningMessage =
- s"Could not alter schema of table
${rawTable.identifier.quotedString} in a Hive " +
- "compatible way. Updating Hive metastore in Spark SQL specific
format."
- logWarning(warningMessage, e)
- client.alterTable(updatedTable.copy(schema =
updatedTable.partitionSchema))
+ val updatedProperties = rawTable.properties ++
tableMetaToTableProps(rawTable, schema)
+
+ // Detect whether this is a Hive-compatible table.
+ val provider = rawTable.properties.get(DATASOURCE_PROVIDER)
+ val isHiveCompatible = if (provider.isDefined && provider !=
Some(DDLUtils.HIVE_PROVIDER)) {
--- End diff --
I think you mean the check below in the `case _ =>` case, right?
I see that both compatible and non-compatible tables set that property, at
least in 2.1, so let me see if there's an easy way to differentiate that
without having to replicate all the original checks (which may be hard to do at
this point).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
