Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18849#discussion_r132012423
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -1998,3 +2001,61 @@ class HiveDDLSuite
         }
       }
     }
    +
    +/**
    + * A separate set of DDL tests that uses Hive 2.1 libraries, which behave 
a little differently
    + * from the built-in ones.
    + */
    +@ExtendedHiveTest
    +class Hive_2_1_DDLSuite extends SparkFunSuite with TestHiveSingleton with 
BeforeAndAfterEach
    --- End diff --
    
    Could we create a separate suite for this? `HiveDDLSuite.scala` is too big 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to