Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18869#discussion_r131754182
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -484,7 +501,20 @@ object Equality {
     }
     
     @ExpressionDescription(
    -  usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` equals `expr2`, or 
false otherwise.")
    +  usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` equals `expr2`, or 
false otherwise.",
    +  arguments = """
    +    Arguments:
    +      * expr1, expr2 - the two expressions must be same type.
    --- End diff --
    
    Regarding the type issues, could you check whether this statement is true? 
I think we can support different types. 
    ```SQL
    SELECT 1 = '1'
    ```
    This will return true.
    
    Also, could you add a test case? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to