Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18869#discussion_r132088507
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -564,8 +611,27 @@ case class EqualNullSafe(left: Expression, right: 
Expression) extends BinaryComp
       }
     }
     
    +// scalastyle:off line.size.limit
     @ExpressionDescription(
    -  usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` is less than 
`expr2`.")
    +  usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` is less than 
`expr2`.",
    +  arguments = """
    +    Arguments:
    +      * expr1, expr2 - the two expressions must be same type or can be 
casted to a common type, and must be a type that can be ordered/compared.
    --- End diff --
    
    @viirya, BTW, I think we could also do this as below:
    
    ```diff
    -      * expr1, expr2 - the two expressions must be same type or can be 
casted to a common type, and must be a type that can be ordered/compared.
    +      * expr1, expr2 - the two expressions must be same type or can be 
casted to a common type,
    +          and must be a type that can be ordered/compared.
    ```
    
    Just double checked it renders fine in the doc as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to