Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18865#discussion_r131796980
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -114,7 +114,16 @@ class JsonFileFormat extends TextBasedFileFormat with
DataSourceRegister {
}
(file: PartitionedFile) => {
- val parser = new JacksonParser(actualSchema, parsedOptions)
+ // SPARK-21610: when the `requiredSchema` only contains
`_corrupt_record`,
--- End diff --
Hm, I understood it fixes the issue described in the JIRA but won't this
introduce casting tries for all columns when the requested schema is empty? I
think this one is a rather band-aid fix. I mean, I think if the `actualSchema`
has few columns selected from many columns, it'd introduce similar problem
again ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
