Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18865#discussion_r131895717
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
 ---
    @@ -114,7 +114,16 @@ class JsonFileFormat extends TextBasedFileFormat with 
DataSourceRegister {
         }
     
         (file: PartitionedFile) => {
    -      val parser = new JacksonParser(actualSchema, parsedOptions)
    +      // SPARK-21610: when the `requiredSchema` only contains 
`_corrupt_record`,
    --- End diff --
    
    Yeah, we've also considered this possibility. But currently we thought a 
query like `dfFromFile.select($"_corrupt_record")` shows all nulls looks 
countering intuition because the query is intended to get the corrupt records 
among the JSON records. That is why we provide a fix like current one. IMO, 
it's meaningless to have all nulls for `_corrupted_record`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to