Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18880#discussion_r131857646
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala 
---
    @@ -751,12 +752,14 @@ private[spark] class Client(
           // by AM.
           Option(amKeytabFileName).foreach { k => 
props.setProperty(KEYTAB.key, k) }
           confStream.putNextEntry(new ZipEntry(SPARK_CONF_FILE))
    -      val writer = new OutputStreamWriter(confStream, 
StandardCharsets.UTF_8)
    +      writer = new OutputStreamWriter(confStream, StandardCharsets.UTF_8)
    --- End diff --
    
    Closing confStream was already sufficient here.  I think this is cleaner 
with a nested try, or if you like, just closing this object after flushing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to