Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r131857298
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java ---
@@ -291,24 +291,14 @@ private Properties loadPropertiesFile() throws
IOException {
}
if (propsFile.isFile()) {
- FileInputStream fd = null;
- try {
- fd = new FileInputStream(propsFile);
- props.load(new InputStreamReader(fd, StandardCharsets.UTF_8));
+ try (InputStreamReader isr = new InputStreamReader(
--- End diff --
Although closing the FileInputStream was already sufficient, this is cleaner
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
