Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18818#discussion_r132002008
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -453,6 +453,14 @@ case class Or(left: Expression, right: Expression) 
extends BinaryOperator with P
     
     abstract class BinaryComparison extends BinaryOperator with Predicate {
     
    +  override def inputType: AbstractDataType = AnyDataType
    --- End diff --
    
    We have to write the code comments for explaining it. Given this 
assumption, `inputType` might be misused in the future. 
    
    In addition, this PR has a pretty critical change. We really need to check 
all the new data types we support in this PR.  
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala#L90-L97
    
    Could you write a comprehensive test case coverage for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to