Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18818#discussion_r132124067
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -465,7 +475,7 @@ abstract class BinaryComparison extends BinaryOperator 
with Predicate {
         }
       }
     
    -  protected lazy val ordering = 
TypeUtils.getInterpretedOrdering(left.dataType)
    +  protected lazy val ordering: Ordering[Any] = 
TypeUtils.getInterpretedOrdering(left.dataType)
    --- End diff --
    
    As `ordering` is lazily accessed, and any nulls don't lead us to access it 
in those predicates,`NullType` should be safe. We should add related test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to