Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18519#discussion_r132034176
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -41,8 +45,11 @@ import org.apache.spark.util.{RpcUtils, 
SerializableBuffer, ThreadUtils, Utils}
      * (spark.deploy.*).
      */
     private[spark]
    -class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val 
rpcEnv: RpcEnv)
    -  extends ExecutorAllocationClient with SchedulerBackend with Logging
    +class CoarseGrainedSchedulerBackend(
    +    scheduler: TaskSchedulerImpl,
    +    val rpcEnv: RpcEnv,
    +    hadoopDelegationTokenManager: Option[HadoopDelegationTokenManager])
    --- End diff --
    
    I'm a little torn on having this as a constructor argument. It seems 
cleaner at first, but it kinda make the constructor of sub-classes (like the 
mesos one) kinda ugly.
    
    How about having a `protected val hadoopDelegationTokenManager = None` and 
overriding it where needed? That makes initialization in the sub-class more 
readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to