Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18810#discussion_r132106108
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -356,6 +356,18 @@ class CodegenContext {
       private val placeHolderToComments = new mutable.HashMap[String, String]
     
       /**
    +   * Returns if the length of codegen function is too long or not
    +   * It will count the lines of every codegen function, if there is a 
function of length
    +   * greater than spark.sql.codegen.MaxFunctionLength, it will return true.
    +   */
    +  def existTooLongFunction(): Boolean = {
    +    classFunctions.exists { case (className, functions) =>
    +      functions.exists{ case (name, code) =>
    +        CodeFormatter.stripExtraNewLines(code).count(_ == '\n') > 
SQLConf.get.maxFunctionLength
    --- End diff --
    
    Like what @viirya said, could you need to check whether it excludes the 
comments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to