Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18820#discussion_r132126123 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1446,21 +1457,21 @@ def all_of_(xs): if isinstance(to_replace, (float, int, long, basestring)): to_replace = [to_replace] - if isinstance(value, (float, int, long, basestring)): - value = [value for _ in range(len(to_replace))] - if isinstance(to_replace, dict): rep_dict = to_replace if value is not None: warnings.warn("to_replace is a dict and value is not None. value will be ignored.") else: + if isinstance(value, (float, int, long, basestring)) or value is None: --- End diff -- Yeah, really confusing. :)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org