Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131815429
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala ---
@@ -145,8 +145,8 @@ class DataTypeSuite extends SparkFunSuite {
val message = intercept[SparkException] {
left.merge(right)
}.getMessage
- assert(message.equals("Failed to merge fields 'b' and 'b'. " +
- "Failed to merge incompatible data types FloatType and LongType"))
+ assert(message === "Failed to merge fields 'b' and 'b'. " +
--- End diff --
It is a valid improvement but it makes backporting harder sometimes. Let's
revert this one if we are fine. We could tell fixing this one when someone (or
you) happens to fix some codes around here. I guess it is too trivial for a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
