Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18810#discussion_r132366187
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
 ---
    @@ -370,6 +370,14 @@ case class WholeStageCodegenExec(child: SparkPlan) 
extends UnaryExecNode with Co
     
       override def doExecute(): RDD[InternalRow] = {
         val (ctx, cleanedSource) = doCodeGen()
    +    if (ctx.isTooLongGeneratedFunction) {
    +      logWarning("Found too long generated codes and JIT optimization 
might not work, " +
    +        "Whole-stage codegen disabled for this plan, " +
    +        "You can change the config spark.sql.codegen.MaxFunctionLength " +
    +        "to adjust the function length limit:\n "
    +        + s"$treeString")
    +      return child.execute()
    +    }
    --- End diff --
    
    We need to add a test in which we create a query with long generated 
function, and check if whole-stage codegen is disabled for it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to