Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18810#discussion_r132367400
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -572,6 +572,14 @@ object SQLConf {
           "disable logging or -1 to apply no limit.")
         .createWithDefault(1000)
     
    +  val WHOLESTAGE_MAX_LINES_PER_FUNCTION = 
buildConf("spark.sql.codegen.maxLinesPerFunction")
    +    .internal()
    +    .doc("The maximum lines of a single Java function generated by 
whole-stage codegen. " +
    +      "When the generated function exceeds this threshold, " +
    +      "the whole-stage codegen is deactivated for this subtree of the 
current query plan.")
    +    .intConf
    +    .createWithDefault(1500)
    --- End diff --
    
    I tend to not change current behavior of whole-stage codegen. This might 
suddenly let user codes not run in whole-stage codegen unintentionally. Shall 
we make `-1` as default and skip function length check if this config is 
negative?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to